Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Bad escaping of EOL. Use option multistr if needed. #1646

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Disable Bad escaping of EOL. Use option multistr if needed. #1646

merged 1 commit into from
Aug 7, 2019

Conversation

Martii
Copy link
Member

@Martii Martii commented Aug 7, 2019

  • Multi-line strings like this, especially in the original JavaScript spec, are still valid and supported although Template Literals (Strings) are a bit easier to read. e.g. don't nag with this.

Post #1641

@Martii
Disable Bad escaping of EOL. Use option multistr if needed.
aea4e25 
* Multi-line strings like this, especially in the original JavaScript spec, are still valid and supported although Template Literals (Strings) are a bit easier to read. e.g. don't nag with this.


Post OpenUserJS#1641
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. labels Aug 7, 2019
@Martii Martii merged commit 4672eeb into OpenUserJS:master Aug 7, 2019
@Martii Martii deleted the yetAnotherJSHintDisable branch August 7, 2019 09:27
@Martii
Copy link
Member Author

Martii commented Aug 7, 2019 •
edited

Oy!

Ref:

  • ajaxorg/ace/blob/c50e196/lib/ace/mode/javascript_worker.js#L77-L98 ... defaults that get overwritten. Will revisit later to add some of these in as well. Knew there was this but took a really long time to find them. Sure would be nice to have a "getOptions" to see what they are by default to modify (and yes I tried in random testing and got undefined).

Needs:
browser, devel, probably laxcomma, probably laxbreak

No ref:
onevar, passfail,
See https://stackoverflow.com/questions/23097316/how-can-i-make-jshint-indent-options-work#answer-23098280

Skip:
lastsemic, node, esnext (never assume and always allow users to pick with /* jshint esversion: 5 */ ... changing to what they support... plus deprecated syntax in Ace current).

Unsure atm:
expr

Recheck:
multistr vs what is already disabled (checked is covered by this rule so removed in newer PR)
globalstrict vs strict: "global" (mogrified to implied for inline jshint usage... part of eventual sandboxing #53 )

Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Aug 7, 2019
@Martii
Some more JSHint changes
0e62868 
* Unsure about `expr`... "anyone, anyone"
* Reorder a bit and comment code

Post OpenUserJS#1641 and OpenUserJS#1646 (comment)
@Martii Martii mentioned this pull request Aug 7, 2019
Merged
Martii added a commit that referenced this pull request Aug 7, 2019
@Martii
Some more JSHint changes (#1647)
404695f 
* Unsure about `expr`... "anyone, anyone"
* Reorder a bit and comment code

Post #1641 and #1646 (comment)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Martii