Set up a Warning header for minification failure
#923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New dep *rfc2047* to allow external viewing of *UglifyJS2* message warning via header... this one appears to follow the spec as closely as possible unlike some others * No known guarantee that `message`s from *UglifyJS2* will be ISO-8859-1 so Q encode under RFC2047 * Since it is MIME format typically this should be wrapped at 76 characters... however *express*/*node* throws an exception... current deviation from the spec * *express* currently only handles one `Warning` header which isn't to spec as well... see http://expressjs.com/en/api.html#res.set * *node* currently only handles one `Warning` header which isn't spec as well... see https://nodejs.org/api/http.html#http_response_setheader_name_value * *express* should be sending HTTP/1.1 so no matching date should be required for compliance as per spec Ref: * http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.46 Applies to OpenUserJS#432
Martii
added
enhancement
Martii
added a commit
that referenced
this pull request
Mar 9, 2016
Set up a `Warning` header for minification failure Auto-merge
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Mar 10, 2016
… present * Appears that the `«` and the `»` aren't in a *UglifyJS2* code search... so do this on our end so it's more readable Applies to OpenUserJS#432 and post fix for OpenUserJS#923 ... also suggested at mishoo/UglifyJS#1001 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messages from UglifyJS2 will be ISO-8859-1 so Q encode under RFC2047Warningheader which isn't to spec as well... see http://expressjs.com/en/api.html#res.setWarningheader which isn't spec as well... see https://nodejs.org/api/http.html#http_response_setheader_name_valueRef:
Applies to #432
Additional refs:
Adding needs mitigation label for long-term down-the-line revisiting