-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take Windows User "TEMP" variable for $EASYRSA_TEMP_DIR fallback #413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Bonhomme <tincanteksup@gmail.com>
This generally fixes #412 |
I forgot to shellcheck it .. |
Signed-off-by: Richard Bonhomme <tincanteksup@gmail.com>
Windows log (With some debugging):
|
Merged
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
When using Windows, the current working directory is not reliably evaluated. This can be due to user error or possible script bugs. This means that the variable EASYRSA may have an incorrect value, which causes EASYRSA_EXT_DIR to point to an invalid location. Currently, the value of EASYRSA_EXT_DIR is assumed to be correct, without verification. Always verify that x509-types folder can be found or error-exit. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
I expect 69b7891 is the reason this cannot be merged. Closing this to do a cleaner PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Richard Bonhomme tincanteksup@gmail.com