Bugfix/spaces in path #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For EC algorithm the variable $EASYRSA_ALGO_PARAMS is a path and needs to be quoted. This also fixes OpenVPN#408
$EASYRSA_PKI is a path that could contain spaces where word splitting must be prevented.
The openssl call relied on word splitting for $crypto_ops but $crypto_opts consists of a path which could contain spaces. Now path is stored in $pass_opts which is quoted when using in openssl call.
while moving them if filename contains spaces.
|
I can feel your pain .. The changes here will not be overlooked - Thanks! |
TinCanTech
added
shellcheck
TinCanTech
reviewed
Mar 22, 2022
There was a problem hiding this comment.
This has been partially addressed by and conflicts with 8e7bac6
|
@markus-t314 these changes here are important. I am happy to work with you to resolve the new conflicts. |
|
Oh sorry, I was not available this last week. |
|
All done. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of issues when the path to
easyrsaorpkicontains spaces.The problem is that in some cases arguments for
openssl-calls can contain paths. When those arguments are not quoted and intentionally used for word splitting, paths with spaces are wrongly split andopenssl-calls fail.The fix is to keep paths in a separate variable and to quote it.
Some minor re-formating issues were also addressed to be more consistent with the existing code style.
This PR fixes issues #395 #408 #412
It also supersedes PR #413 as it fixes space-related problems on Linux as well.