Fix missing PRODUCT_PUBLISHER field in installer #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the Product Publisher in Programs and Features is listed as
`${PRODUCT_PUBLISHER}` instead of "OpenVPN Technologies, Inc." as
reported on IRC.
This patch adds the `PRODUCT_PUBLISHER` variable to the buildtap.py
invocation of MakeNSIS. It also allows for `MakeNSIS` invocations with
spaces in them.
jkunkee
force-pushed
the
fix-product_publisher
branch
from
0622746
to
6eee771
Compare
|
Looks good. I assume the extra quotes are because value of PRODUCT_PUBLISHER has spaces in it? |
|
Precisely. There are a few other character classes (parentheses, pipes, ampersands, etc.) that it can take care of too.
…Sent from my Windows 10 phone
[15254 - 16.0.9226.2120]
From: Samuli Seppänen
Sent: Sunday, April 29, 2018 4:01 AM
To: OpenVPN/tap-windows6
Cc: Jon Kunkee; Author
Subject: Re: [OpenVPN/tap-windows6] Fix missing PRODUCT_PUBLISHER field ininstaller (#51)
Looks good. I assume the extra quotes are because value of PRODUCT_PUBLISHER has spaces in it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the
PRODUCT_PUBLISHERvariable to the buildtap.py invocation of MakeNSIS. It also allows forMakeNSISinvocations with spaces in them.This should address the fact that Product Publisher in Programs and Features is
${PRODUCT_PUBLISHER}instead of "OpenVPN Technologies, Inc." as reported on IRC.