Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate circular dependency to fix building with Vite #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spaun
Copy link

@spaun spaun commented Nov 22, 2021

No description provided.

@joker-x
Copy link

joker-x commented May 23, 2022

I am very interesting in this pull request was merged if it works fine. Can I help?

@manoelcfeliciano
Copy link

manoelcfeliciano commented Aug 2, 2022

I can certify that the changes suggested by @spaun works as expected. I ported his changes to the latest version of OpenVidu (2.22.0) and got it working on my projects.

I guess we can merge this without any problem. Any thoughts from the maintainers here would be appreciated.

@pabloFuente @CSantosM @j1elo @cruizba

@CSantosM CSantosM force-pushed the master branch 10 times, most recently from bfa4d17 to 33d1192 Compare July 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants