Skip to content

Commit

Permalink
Worked around the increased BDBR regression issue.
Browse files Browse the repository at this point in the history
The regression was caused by the tile group implementation (PR #348),
when ImproveSharpness is used, as it would impact the QP values of
each CU and latter mode decision process.

So temporarily work around the issue and need to fix it in the future.

Signed-off-by: Austin Hu <austin.hu@intel.com>
  • Loading branch information
Austin-Hu committed Nov 19, 2019
1 parent 58b3593 commit f126f32
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Source/Lib/Codec/EbPictureDecisionProcess.c
Original file line number Diff line number Diff line change
Expand Up @@ -1020,9 +1020,14 @@ void* PictureDecisionKernel(void *inputPtr)

pictureControlSetPtr->disableTmvpFlag = sequenceControlSetPtr->staticConfig.unrestrictedMotionVector == 0 ? EB_TRUE : EB_FALSE;

// FIXME: work around the increased BDBR regression issue induced by the
// tile group implementation (PR #348), when ImproveSharpness is used.
#if 0
pictureControlSetPtr->useSrcRef = (sequenceControlSetPtr->staticConfig.improveSharpness && pictureControlSetPtr->temporalLayerIndex > 0) ?
EB_TRUE :
EB_FALSE;
#endif
pictureControlSetPtr->useSrcRef = EB_FALSE;

SignalDerivationMultiProcessesOq(
sequenceControlSetPtr,
Expand Down

0 comments on commit f126f32

Please sign in to comment.