Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Remove SimpleApp #174

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Remove SimpleApp #174

merged 1 commit into from
Apr 11, 2019

Conversation

1480c1
Copy link
Member

@1480c1 1480c1 commented Apr 8, 2019

No description provided.

@tianjunwork tianjunwork added the Clean up A cleaner implementation or improved functionality label Apr 8, 2019
@lijing0010
Copy link
Contributor

why remove this simple app?

@1480c1
Copy link
Member Author

1480c1 commented Apr 9, 2019

Similar to https://github.com/OpenVisualCloud/SVT-AV1/pull/197
and https://github.com/OpenVisualCloud/SVT-AV1/issues/186
It doesn't seem like a good idea to have to support two executables that essentially do the same thing, one just a stripped down version with different command line options.
Plus in the future, it will be hard to maintain parity and ensure that both work properly.

@tianjunwork tianjunwork merged commit 2bdfb22 into OpenVisualCloud:master Apr 11, 2019
@1480c1 1480c1 deleted the removesimpleapp branch April 12, 2019 17:28
@tianjunwork tianjunwork mentioned this pull request Nov 28, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tianjunwork tianjunwork tianjunwork approved these changes

@lijing0010 lijing0010 Awaiting requested review from lijing0010

Assignees
No one assigned
Labels
Clean up A cleaner implementation or improved functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1480c1 @lijing0010 @tianjunwork