Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameError: name '_get_skill_dirs' is not defined. #159

Closed
Ramblurr opened this issue Dec 29, 2023 · 1 comment · Fixed by #161
Closed

NameError: name '_get_skill_dirs' is not defined. #159

Ramblurr opened this issue Dec 29, 2023 · 1 comment · Fixed by #161

Comments

@Ramblurr
Copy link

for p in _get_skill_dirs():

Commit 308ff2d4430442c10cb077003ba51cf305fb1b67 broke the skill launcher, crashing some skills: chatgpt fallback, and mikejgray/neon-homeassistant-skill

2023-12-29 10:14:28.163 - OVOS - ovos_utils.intents.intent_service_interface:<module>:8 - WARNING - Deprecation version=0.1.0. Caller=ovos_utils.intents:1. ovos_utils.intents moved to ovos_workshop.intents
2023-12-29 10:14:28.179 - OVOS - ovos_utils.intents.converse:<module>:7 - WARNING - Deprecation version=0.1.0. Caller=ovos_utils.intents:3. ConverseTracker has been deprecated without replacement
2023-12-29 10:14:28.192 - OVOS - ovos_utils.intents.layers:<module>:3 - WARNING - Deprecation version=0.1.0. Caller=ovos_utils.intents:4. IntentLayers moved to ovos_workshop.decorators.layers
2023-12-29 10:14:28.206 - OVOS - ovos_utils.intents:<module>:7 - WARNING - Deprecation version=0.1.0. Caller=ovos_utils.events:7. ovos_utils.intents moved to ovos_workshop.intents
2023-12-29 10:14:28.342 - OVOS - ovos_utils.enclosure:<module>:8 - WARNING - Deprecation version=0.1.0. Caller=ovos_plugin_manager.templates.tts:41. ovos_utils.enclosure has been deprecated!
2023-12-29 10:14:28.380 - OVOS - ovos_utils.enclosure.api:<module>:3 - WARNING - Deprecation version=0.1.0. Caller=ovos_plugin_manager.templates.tts:41. EnclosureApi has moved to ovos_bus_client.apis.enclosure
2023-12-29 10:14:28.401 - OVOS - ovos_utils.skills.locations:<module>:10 - WARNING - Deprecation version=0.1.0. Caller=ovos_utils.skills:3. ovos_utils.skills.locations moved to ovos_plugin_manager.skills
2023-12-29 10:14:28.474 - OVOS - mycroft:<module>:37 - WARNING - mycroft has been deprecated! please start importing from ovos_core and companion packages
mycroft module remains available for backwards compatibility and will be removed in version 0.2.0
Traceback (most recent call last):
  File "/home/ovos/.venv/bin/ovos-skill-launcher", line 8, in <module>
    sys.exit(_launch_script())
             ^^^^^^^^^^^^^^^^
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 657, in _launch_script
    skill = SkillContainer(skill_id)
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_workshop/skill_launcher.py", line 566, in __init__
    for p in _get_skill_dirs():
             ^^^^^^^^^^^^^^^
NameError: name '_get_skill_dirs' is not defined. Did you mean: 'get_skill_class'?
@j1nx
Copy link
Member

j1nx commented Dec 29, 2023

Some great, big development sprint is going on currently. I have reported similar issues over at the Matrix channels.

Guess we caught the Python guru's in the middle of their work, so let's be patience and wait and see.

Keep you posted.

JarbasAl added a commit that referenced this issue Dec 29, 2023
JarbasAl added a commit that referenced this issue Dec 29, 2023
* fix skill_directories

closes #159

* tests belong in OPM
@github-actions github-actions bot mentioned this issue Dec 29, 2023
@github-actions github-actions bot mentioned this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants