Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init #120

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix init #120

merged 1 commit into from
Jul 14, 2023

Conversation

JarbasAl
Copy link
Member

closes #119 maybe

closes #119 maybe
@JarbasAl JarbasAl added the bug Something isn't working label Jul 14, 2023
@JarbasAl JarbasAl requested a review from NeonDaniel July 14, 2023 13:51
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #120 (ecc409d) into dev (0cdf027) will increase coverage by 58.63%.
The diff coverage is 79.54%.

@@            Coverage Diff             @@
##             dev     #120       +/-   ##
==========================================
+ Coverage   0.00%   58.63%   +58.63%     
==========================================
  Files         33       33               
  Lines       3173     3244       +71     
==========================================
+ Hits           0     1902     +1902     
+ Misses      3173     1342     -1831     
Impacted Files Coverage Δ
ovos_workshop/decorators/converse.py 0.00% <0.00%> (ø)
ovos_workshop/decorators/fallback_handler.py 0.00% <0.00%> (ø)
ovos_workshop/skills/active.py 100.00% <ø> (+100.00%) ⬆️
ovos_workshop/skills/decorators/__init__.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/converse.py 0.00% <0.00%> (ø)
...vos_workshop/skills/decorators/fallback_handler.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/killable.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/layers.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/ocp.py 0.00% <0.00%> (ø)
ovos_workshop/skills/intent_provider.py 0.00% <0.00%> (ø)
... and 18 more

... and 4 files with indirect coverage changes

@JarbasAl JarbasAl marked this pull request as ready for review July 14, 2023 14:00
@JarbasAl JarbasAl merged commit 0d1fce9 into dev Jul 14, 2023
12 checks passed
@JarbasAl JarbasAl deleted the fix-init branch July 14, 2023 14:02
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHAL and admin PHAL failures to successfully initialize started evening of Jul 13
1 participant