CommonQuerySkill handler complete event and tests #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional equivalent to `mycroft.skill.handler.complete`) Adds docstrings and type annotations to CommonQuerySkill base class Adds minimal tests for CommonQuerySkill
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #142 +/- ##
=======================================
Coverage 60.24% 60.24%
=======================================
Files 34 34
Lines 3325 3328 +3
=======================================
+ Hits 2003 2005 +2
- Misses 1322 1323 +1
☔ View full report in Codecov by Sentry. |
JarbasAl
reviewed
Oct 10, 2023
NeonDaniel
pushed a commit
to NeonGeckoCom/neon-utils
that referenced
this pull request
Oct 10, 2023
JarbasAl
approved these changes
Oct 10, 2023
NeonDaniel
added a commit
to NeonGeckoCom/neon-utils
that referenced
this pull request
Oct 10, 2023
* Back-port OpenVoiceOS/OVOS-workshop#142 * Resolve license test failure Refactor for upstream ovos-workshop compat. * Troubleshooting compat. with upstream `settings_path` changes * More test failure troubleshooting * Fix bad references to inherited properties * More settings_path troubleshooting --------- Co-authored-by: Daniel McKnight <daniel@neon.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit
question:handler_completewhen a CQS action is completed (functional equivalent tomycroft.skill.handler.complete)Adds docstrings and type annotations to CommonQuerySkill base class Adds minimal tests for CommonQuerySkill