Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/extend_ovosskill #143

Merged
merged 4 commits into from
Oct 10, 2023
Merged

feat/extend_ovosskill #143

merged 4 commits into from
Oct 10, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 10, 2023

extend skill class to include support for language plugins:

extend self.activate:

  • allow skills to specify how long they want to remain active
  • api compat with NeonSkill class to reduce divergence
  • TODO - companion PR in core

extend skill class to include support for language plugins:
- makes it easier to share the underlying object with the solver plugins
- TODO - companion PR in OPM
- api compat with NeonSkill class to reduce divergence
- lazy init on first usage, no extra resource usage in existing skills

extend self.activate:
- allow skills to specify how long they want to remain active
- api compat with NeonSkill class to reduce divergence
- TODO - companion PR in core
@JarbasAl JarbasAl added the enhancement New feature or request label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (7cf8e4e) 60.24% compared to head (6fbebbc) 59.98%.
Report is 8 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #143      +/-   ##
==========================================
- Coverage   60.24%   59.98%   -0.26%     
==========================================
  Files          34       34              
  Lines        3325     3409      +84     
==========================================
+ Hits         2003     2045      +42     
- Misses       1322     1364      +42     
Files Coverage Δ
ovos_workshop/skills/auto_translatable.py 28.45% <ø> (-1.15%) ⬇️
ovos_workshop/version.py 0.00% <0.00%> (ø)
ovos_workshop/skills/ovos.py 72.92% <66.66%> (-0.23%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ovos_workshop/skills/ovos.py Outdated Show resolved Hide resolved
ovos_workshop/skills/ovos.py Outdated Show resolved Hide resolved
@JarbasAl JarbasAl marked this pull request as ready for review October 10, 2023 18:04
@JarbasAl JarbasAl merged commit 4f65ac5 into dev Oct 10, 2023
8 of 9 checks passed
@JarbasAl JarbasAl deleted the feat/extend_skillclass branch October 10, 2023 18:53
This was referenced Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants