Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to remove fallback (handler) #150

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Dec 10, 2023

two things in question:

  • register with core fallback service only if handler present - ie. register_fallback called upon the skill
  • remove fallback (handler) in full (and consequentially deregister)

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (4f65ac5) 60.23% compared to head (924ebe7) 59.66%.
Report is 17 commits behind head on dev.

Files Patch % Lines
ovos_workshop/skills/ovos.py 24.48% 37 Missing ⚠️
ovos_workshop/skills/fallback.py 85.71% 2 Missing ⚠️
ovos_workshop/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #150      +/-   ##
==========================================
- Coverage   60.23%   59.66%   -0.57%     
==========================================
  Files          34       34              
  Lines        3347     3384      +37     
==========================================
+ Hits         2016     2019       +3     
- Misses       1331     1365      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added the enhancement New feature or request label Dec 12, 2023
@JarbasAl JarbasAl merged commit c53caf9 into OpenVoiceOS:dev Dec 12, 2023
7 of 8 checks passed
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants