Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update warning log to use log_deprecation helper #188

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

NeonDaniel
Copy link
Member

Updates deprecation log to include more context

@NeonDaniel NeonDaniel requested a review from a team March 2, 2024 01:35
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@a69b375). Click here to learn what that means.

Files Patch % Lines
ovos_workshop/resource_files.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #188   +/-   ##
======================================
  Coverage       ?   53.51%           
======================================
  Files          ?       36           
  Lines          ?     3737           
  Branches       ?        0           
======================================
  Hits           ?     2000           
  Misses         ?     1737           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeonDaniel NeonDaniel marked this pull request as draft March 2, 2024 01:41
@NeonDaniel NeonDaniel marked this pull request as ready for review March 2, 2024 01:57
@JarbasAl JarbasAl merged commit 2f742ff into dev Mar 5, 2024
9 checks passed
@JarbasAl JarbasAl deleted the LOG_DeprecationLog branch March 5, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants