Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/targeted OCP queries #195

Merged
merged 1 commit into from
Apr 9, 2024
Merged

feat/targeted OCP queries #195

merged 1 commit into from
Apr 9, 2024

Conversation

NeonJarbas
Copy link
Contributor

allows ovos-media to query individual OCP skills

@JarbasAl
feat/targeted OCP queries
ba9d485 
allows ovos-media to query individual OCP skills
@JarbasAl JarbasAl added the enhancement New feature or request label Apr 9, 2024
@JarbasAl JarbasAl requested review from NeonDaniel and a team April 9, 2024 12:37
@JarbasAl JarbasAl mentioned this pull request Apr 9, 2024
Merged
@NeonJarbas NeonJarbas mentioned this pull request Apr 9, 2024
Merged
NeonDaniel
NeonDaniel approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, we'll need unit tests probably here and in ovos-core where these messages are emitted

@JarbasAl JarbasAl merged commit 75ce5d3 into OpenVoiceOS:dev Apr 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeonJarbas @NeonDaniel @JarbasAl