Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/mycroft_backwards_compat #206

Merged
merged 9 commits into from
Jun 2, 2024
Merged

fix/mycroft_backwards_compat #206

merged 9 commits into from
Jun 2, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl added the bug Something isn't working label May 28, 2024
@JarbasAl JarbasAl requested review from mikejgray, NeonDaniel and a team May 28, 2024 06:16
@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited

Codecov Report

Attention: Patch coverage is 42.50000% with 23 lines in your changes are missing coverage. Please review.

Please upload report for BASE (dev@3865f04). Learn more about missing BASE report.

Files Patch % Lines
ovos_workshop/skills/mycroft_skill.py 45.71% 19 Missing ⚠️
ovos_workshop/skills/ovos.py 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             dev     #206   +/-   ##
======================================
  Coverage       ?   54.57%           
======================================
  Files          ?       36           
  Lines          ?     3952           
  Branches       ?        0           
======================================
  Hits           ?     2157           
  Misses         ?     1795           
  Partials       ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl mentioned this pull request May 28, 2024
Merged
@NeonDaniel NeonDaniel mentioned this pull request May 30, 2024
Open
4 tasks
@JarbasAl JarbasAl mentioned this pull request May 31, 2024
Merged
@JarbasAl JarbasAl marked this pull request as ready for review May 31, 2024 18:11
@JarbasAl JarbasAl requested a review from NeonDaniel May 31, 2024 18:14
NeonDaniel pushed a commit to NeonGeckoCom/neon-utils that referenced this pull request May 31, 2024
Update dependency to validate OpenVoiceOS/OVOS-workshop#206
8a8e970
@JarbasAl JarbasAl merged commit d7d0ae8 into dev Jun 2, 2024
9 checks passed
@JarbasAl JarbasAl deleted the fix/mycroft_backwards_compat branch June 2, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel requested changes

@mikejgray mikejgray Awaiting requested review from mikejgray

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JarbasAl @NeonDaniel