Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/filesystem_path #133

Merged
merged 6 commits into from Jun 5, 2022
Merged

Conversation

NeonJarbas
Copy link

  • the path from filesystem was wrong due to a variable name collision, this affected skill data and identity file location
  • filesystem was wrongly using xdg_config instead of xdg_data
  • refactor identity manager to not use filesystem helper class, that class is meant for skills and now that we are XDG compliant it can not be used or it will move the location of the identity file

point 2 and 3 are bugs that canceled each other out

the path from filesystem was wrong due to a variable name collision

this affected skill data and identity file location
data and config are now separated, each in the corresponding XDG compliant directory
@JarbasAl JarbasAl requested a review from NeonDaniel June 4, 2022 23:36
@JarbasAl JarbasAl added bug Something isn't working bug-ovos labels Jun 4, 2022
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #133 (1e0fbfd) into dev (6ceb058) will increase coverage by 2.49%.
The diff coverage is 41.72%.

@@            Coverage Diff             @@
##              dev     #133      +/-   ##
==========================================
+ Coverage   50.35%   52.84%   +2.49%     
==========================================
  Files         119      150      +31     
  Lines       10077     9601     -476     
==========================================
  Hits         5074     5074              
+ Misses       5003     4527     -476     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c5d49...1e0fbfd. Read the comment docs.

@JarbasAl JarbasAl merged commit ad48cf8 into OpenVoiceOS:dev Jun 5, 2022
@j1nx
Copy link
Member

j1nx commented Jun 5, 2022

Am I correct that this will solve the mystery created files at the wrong/old home directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants