refactor/ovos-core!! #313
Merged
refactor/ovos-core!! #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added
refactor
JarbasAl
requested review from
goldyfruit,
j1nx,
ChanceNCounter,
AIIX,
emphasize,
NeonDaniel,
builderjer and
a team
JarbasAl
added a commit
that referenced
this pull request
Apr 25, 2023
this makes setup.py provide 2 packages when installing core minimal needed code to run the skills service lives in ovos_core goodbye `from mycroft import *`! the mycroft module remains only for backwards compatibility, downstream should start importing `ovos_core`
Closed
JarbasAl
force-pushed
the
refactor/double_pkg
branch
2 times, most recently
from
42dac41
to
0bbce85
Compare
JarbasAl
force-pushed
the
refactor/double_pkg
branch
from
bb2ce3d
to
b75d6f5
Compare
emphasize
approved these changes
May 1, 2023
JarbasAl
force-pushed
the
refactor/double_pkg
branch
from
e528cf8
to
40c3944
Compare
this makes setup.py provide 2 packages when installing core minimal needed code to run the skills service lives in ovos_core goodbye `from mycroft import *`! the mycroft module remains only for backwards compatibility, downstream should start importing `ovos_core`
JarbasAl
force-pushed
the
refactor/double_pkg
branch
from
14d7bd8
to
674b6d7
Compare
Codecov Report
@@ Coverage Diff @@
## dev #313 +/- ##
===========================================
- Coverage 50.35% 12.42% -37.93%
===========================================
Files 119 10 -109
Lines 10077 1400 -8677
===========================================
- Hits 5074 174 -4900
+ Misses 5003 1226 -3777 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes setup.py provide 2 packages when installing core
minimal needed code to run the skills service lives in ovos_core
goodbye
from mycroft import *!the mycroft module remains only for backwards compatibility, downstream should start importing
ovos_corereplaces #197