Fix custom units from utterance #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: ATM it is not possible to change the temperature unit per utterance.
This introduces a new property/attribute
scaleboth toWeatherConfigandWeatherIntentfrom which the units (temperature/wind) is derived and fixes a bug where the spoken unit would be sent as a api request param10.89.0.6 - - [04/Apr/2023 11:25:36] "GET /v1/owm/onecall?exclude=minutely&lang=de&lat=49.5875&lon=8.35778&units=fahrenheit HTTP/1.1" 200 -# has to metric/imperialFurthermore weather reports can now also be requested in a different unit.
This is in line with what i intent to add later on, namely pass
SkillRessourcesto the dialog class to be able to translate there.this closes #31 and replaces #8