Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend intents #47

Merged
merged 4 commits into from
May 22, 2023
Merged

extend intents #47

merged 4 commits into from
May 22, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented May 21, 2023

report any currently failing utterances that should match a weather intent here please

@JarbasAl JarbasAl added the enhancement New feature or request label May 21, 2023
@JarbasAl JarbasAl requested review from emphasize and a team May 21, 2023 19:54
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #47 (d665eb5) into dev (6a3be70) will decrease coverage by 3.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #47      +/-   ##
==========================================
- Coverage   29.57%   26.10%   -3.47%     
==========================================
  Files           9        8       -1     
  Lines        1055     1061       +6     
==========================================
- Hits          312      277      -35     
- Misses        743      784      +41     
Flag Coverage Δ
unittests 26.10% <ø> (-3.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

@mikejgray
Copy link

Additional suggestions

is there a storm coming
is there a chance of showers

@emphasize
Copy link
Member

is there a storm coming

would need a new intent/condition handling

is there a chance of showers

Handled with handle_next_precipitation? Regardless, this raises the question if when.voc and query.voc shouldn't be merged. "when" is a query. Or, as Jarbas suggested transition to padatious. Both out of scope here.

I'm disentangling this and will open a new issue to propose such new stuff. Want to get the language support ASAP.

@emphasize emphasize merged commit e9dbc8d into dev May 22, 2023
9 of 10 checks passed
@emphasize emphasize deleted the feat/extend_intents branch May 22, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants