xrGame: fix ability to get a negative money balance after paid service #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Money was checked when player press to a some question in dialog. If player by buy something at this moment, then your money state will be changed, but a condition for a service dialog wil not be rechecked. How: Just reset a talk dialog state to initial when player press to a trade button. Issue: OpenXRay#1173
|
From what I can guess, this can potentially cause more problems with broken dialog lines: you selected some phrase which triggered a dialog line, then switched to trade – now that line is broken: not all phrases finished, but you can't restart it again. We need to recheck if this approach can cause such problems or existing dialog system won't allow that and we can merge this. For now, I think we need to improve money system itself – make it more hardened, prevent situations when money balance can turn negative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Money was checked when player press to a some question in dialog. If player by buy something at this moment, then your money state will be changed, but a condition for a service dialog wil not be rechecked.
How:
Just reset a talk dialog state to initial when player press to a trade button.
Issue: #1173