Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindReadline.cmake typo preventing cmake config #719

Closed
iq2luc opened this issue Jan 21, 2021 · 4 comments · Fixed by #720
Closed

FindReadline.cmake typo preventing cmake config #719

iq2luc opened this issue Jan 21, 2021 · 4 comments · Fixed by #720
Labels
Build issue The issue in the build-time. Linux Portability

Comments

@iq2luc
Copy link
Contributor

iq2luc commented Jan 21, 2021 •
edited

Description
CMake configuration: shared library libreadline.so not found due to a typo in FindReadline.cmake.
Also see: #707 (review)

Steps to reproduce

  1. Configure via CMake on Linux (Archlinux distro)
  2. FindReadline.cmake cannot find libreadline.so

Suggested patch
FixCMakeFindReadline.patch.txt
@iq2luc iq2luc added the Bug The issue in the run-time. label Jan 21, 2021
@Xottab-DUTY
Copy link
Member

Can you open a pull request?

@Xottab-DUTY Xottab-DUTY added Build issue The issue in the build-time. Linux Portability and removed Bug The issue in the run-time. labels Jan 21, 2021
@iq2luc
Copy link
Contributor Author

iq2luc commented Jan 21, 2021

Never did that before (the pull request thingy on github) but if that's the only way for this small issue to be fixed I will try to do it.

@iq2luc
Copy link
Contributor Author

iq2luc commented Jan 21, 2021

OK, done, there's always 'a first'.
Also taking the opportunity to express my appreciation for the extraordinary people working on everything STALKER related. Thank you for the Linux port.

@Xottab-DUTY Xottab-DUTY linked a pull request Jan 21, 2021 that will close this issue
CMake: Fix typo in FindReadline.cmake (fixes #719) #720
Merged
@Xottab-DUTY
Copy link
Member

Thank you too!

Xottab-DUTY pushed a commit that referenced this issue Jan 21, 2021
@iq2luc
CMake: Fix typo in FindReadline.cmake (PR #720, fixes #719)
d52dedf 
Fixes a small typo introduced in #707.
eagleivg pushed a commit to eagleivg/xray-16 that referenced this issue Jan 23, 2021
@iq2luc @eagleivg
CMake: Fix typo in FindReadline.cmake (PR OpenXRay#720, fixes OpenXRa…
170fd94 
…y#719)

Fixes a small typo introduced in OpenXRay#707.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build issue The issue in the build-time. Linux Portability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMake: Fix typo in FindReadline.cmake (fixes #719)
2 participants
@Xottab-DUTY @iq2luc