Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ".dll" suffix from LoadModule calls. #78

Closed
Kaffeine opened this issue Nov 14, 2015 · 3 comments
Closed

Remove ".dll" suffix from LoadModule calls. #78

Kaffeine opened this issue Nov 14, 2015 · 3 comments

Comments

@Kaffeine
Copy link
Member

Remove ".dll" suffix from LoadModule calls.

The final goal is to make LoadModule calls platform-independent (we have ".dll" on Windows and ".so" on Linux/Mac)

https://github.com/OpenXRay/xray-16/blob/ai_cleanup/src/xrEngine/EngineAPI.cpp#L135 and so on.

Note: we need to verify that the game works with the changes.

@nitrocaster
Copy link
Member

we need to verify that the game works with the changes.

It does work.

@Kaffeine
Copy link
Member Author

It does work.

Well, I meant that after ".dll" suffix removal we need to verify that the game works. You confirmed my suspicious at

Xottab-DUTY@e63a186#commitcomment-14401586

These names are used by hxGrid library. Need to check if it accepts file names without extensions (I suppose it doesn't).

nitrocaster pushed a commit that referenced this issue Nov 20, 2015
Remove ".dll" suffix from LoadModule calls. Close #78.
@Kaffeine
Copy link
Member Author

Thanks.

Closed by commit 9b789e6.

@Kaffeine Kaffeine added this to the Linux port milestone Nov 29, 2015
@Xottab-DUTY Xottab-DUTY added this to Done in Linux port Jul 1, 2018
@Xottab-DUTY Xottab-DUTY mentioned this issue Dec 31, 2020
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linux port
  
Done
Development

No branches or pull requests

3 participants