Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clang-format config #155

Merged
merged 2 commits into from
Jan 14, 2017
Merged

Added clang-format config #155

merged 2 commits into from
Jan 14, 2017

Conversation

invokr
Copy link
Contributor

@invokr invokr commented Jan 13, 2017

Config taken from the dolphin emulator project. See this file as an example of how formated source code would look like: https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/ActionReplay.cpp

I don't mind any specific style as long as it is consistent so I hope someone else will chip in and modify the sections they need. Important points might be such things as column with (cur 100) or ident width (cur 2).

I would run this over all source files and do another pull requests if there is a consensus.

@nitrocaster
Copy link
Member

Just in case if you haven't yet seen the conventions we use: https://github.com/OpenXRay/xray-16/wiki/Cpp-Coding-Conventions

@invokr
Copy link
Contributor Author

invokr commented Jan 13, 2017

I didn't actually know about that, I only saw the old guidelines in text form. I'll update the format config to incorporate as many of the guidelines as possible

@CrossVR
Copy link
Contributor

CrossVR commented Jan 14, 2017

Are we sure we want to base it on the Dolphin code style? Shouldn't we use the LLVM style as a base? clang-format -style=llvm -dump-config > .clang-format

@CrossVR
Copy link
Contributor

CrossVR commented Jan 14, 2017

Meh, using dolphin as the base is fine by me, let's just run this thing and get it over with.

@CrossVR CrossVR merged commit c61a25c into OpenXRay:dev Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants