Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian/: Switch to use gcc-14 #1668

Merged
merged 1 commit into from
May 9, 2024

Conversation

sobkas
Copy link
Contributor

@sobkas sobkas commented May 6, 2024

Switch to use gcc-14
Depends on: #1667

@Xottab-DUTY
Copy link
Member

Xottab-DUTY commented May 7, 2024

Not that long ago I find out that we already have DEB package specs – they are being generated by CMake. If I understand correctly.
That means we have code/logic duplication and, what's worse, these manually created specs are different from what CMake generates.
Are there any disadvantages if we just delete debian folder and move all that logic to CMake files?

@sobkas
Copy link
Contributor Author

sobkas commented May 7, 2024

Static debian/ folder allows me to compile debian packages using my existing infrastructure.
Also debian/ dir is simpler to maintain than CMake.

@Xottab-DUTY Xottab-DUTY merged commit 85e682e into OpenXRay:dev May 9, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants