S9: Cleanup real-time clock support #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save-rtc.sh is pointless. It just calls hwclock.sh stop. hwclock.sh comes from busybox-hwclock and installs its own rc symlinks to stop itself. busybox-hwclock is installed and used in dom0. The uivm and ndvm images remove the initscript calling it and save-rtc.sh since they don't have a hardware clock. Just delete save-rtc.sh since it's not adding anything. Upstream OE has a save-rtc.sh that writes to /etc/timestamp, so that doesn't work with our read-only rootfs images. Signed-off-by: Jason Andryuk <jandryuk@gmail.com> (cherry picked from commit fe7cabb)
dom0 and installer are the only machines that actually talk to a hardware real-time clock. The other virtual machines don't need to work with an rtc, so it can be remove. To actually do so, we need to add it to MACHINE_FEATURES_BACKFILL_CONSIDERED since it defaults enabled when unset. With that we need to explicitly add it for dom0 and installer. Signed-off-by: Jason Andryuk <jandryuk@gmail.com> (cherry picked from commit 662797f)
hwclock.sh is no longer installed, so we can drop the explicit initscript removal. Signed-off-by: Jason Andryuk <jandryuk@gmail.com> (cherry picked from commit bb1cbb8)
hwclock.sh is no longer installed, so we don't need to remove it through PACKAGE_REMOVE. Signed-off-by: Jason Andryuk <jandryuk@gmail.com> (cherry picked from commit 65cd43f)
|
Merging soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the stable-9 version of #1196
Only the Dom0 and Installer machines have access to a hardware real-time clock. By removing 'rtc' from MACHINE_FEATURES (through MACHINE_FEATURES_BACKFILL_CONSIDERED), we also remove the hwclock.sh initscript from the virtual machines.
We can then clean up some image recipes.
save-rtc.sh is redundant, so we can drop that as well.