Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISC: skip CI for commits that do not modify core sources. #3064

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

cebarobot
Copy link
Member

For a long time, modifying files which do not affect CPU core still have to run and pass all CI processes, which could waste a lot of time. This patch introduces dorny/paths-filter@v3 to skip some commits which only modifies edge files such as issue templates, codeowners and readme.

For a long time, modifying files which do not affect CPU core still have to run and pass all CI processes, which could waste a lot of time. This patch introduces dorny/paths-filter@v3 to skip some commits which only modifies edge files such as issue templates, codeowners and readme.
@ngc7331
Copy link
Collaborator

ngc7331 commented Jun 12, 2024

Maybe a path filter could serve the same purpose without requiring a separate "change detection" task?
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

@cebarobot
Copy link
Member Author

Maybe a path filter could serve the same purpose without requiring a separate "change detection" task? https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

This won't work in our case. See this Handling skipped but required checks.

Warning: If a workflow is skipped due to path filtering, branch filtering or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: fa33ed2

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
fa33ed2 1.808 0.447 2.043 1.187 2.938 2.508 2.291 0.921 1.369 1.441 3.454 2.658 2.399 2.932

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
a7828dc 1.808 2.043 1.187 2.938 2.508 0.921 1.369 1.441 3.454 2.399 2.932
9f598f8
e975de6 1.808 0.447 2.043 1.187 2.938 2.508 2.291 0.921 1.369 1.441 3.454 2.658 2.399 2.932
ff9b84b 0.447 2.043 1.187 2.291 0.921 1.369 3.454 2.658 2.932
3bec463 1.808 0.447 2.043 1.187 2.938 2.508 2.291 0.921 1.369 1.441 3.454 2.658 2.399 2.932
2d12882 0.447 2.043 1.187 2.291 0.921 1.369 3.454 2.658 2.932
ef14270 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932
5c5f442 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932
d67c873 1.827 0.448 2.048 1.190 2.938 2.508 2.289 0.932 1.369 1.410 3.445 2.672 2.398 2.932

@Tang-Haojin Tang-Haojin merged commit 49ceda6 into master Jun 13, 2024
5 checks passed
@Tang-Haojin Tang-Haojin deleted the changes-detection branch June 13, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants