Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentAssembler: Support for images #31

Merged
merged 6 commits into from Aug 15, 2021

Conversation

michha
Copy link

@michha michha commented Jul 1, 2021

In our organisation we use a custom Clippit version, where we took a Pull Request for the Open-Xml-PowerTools and applied it on Clippit.
I want to bring this feature to Clippit, so everyone can use it.

@sergey-tihon
Copy link
Owner

sergey-tihon commented Jul 1, 2021

Thank you for this PR @michha !

Can you please briefly describe the feature here or add new docs page if it bring new API/capability. I do my best to document all significant changes.

@sergey-tihon sergey-tihon added the Word Word related tasks label Jul 1, 2021
@michha
Copy link
Author

michha commented Jul 2, 2021

First I want to line out, that this contribution is not our own but from user @krembf that he tried to get into the Microsoft repo back in 2018 (see DocumentAssembler: Support for Images (#42) #236).
In December 2020 user @carzaza tried to get this changes into the fork from Eric White (see DocumentAssembler: Support for images #30).

Because of holidays it will take me some weeks to get a new docs page.

@michha michha changed the title Image support Support for images Jul 2, 2021
# Conflicts:
#	OpenXmlPowerTools.Tests/Word/DocumentAssemblerTests.cs
@sergey-tihon sergey-tihon changed the title Support for images DocumentAssembler: Support for images Jul 5, 2021
@sergey-tihon
Copy link
Owner

I've released code from this branch in v1.7.0-beta1
@michha can you please try it and confirm that it works for you?

@krembf
Copy link

krembf commented Jul 5, 2021

Thanks for mentioning me, @michha!
In case this would be of any help with documentation, I'm attaching some details of the implementation (extracted from the conversation I had with the original owner of the PowerTools.
SupportForImages.docx

@michha
Copy link
Author

michha commented Jul 26, 2021

I've released code from this branch in v1.7.0-beta1
@michha can you please try it and confirm that it works for you?

Our use cases are working with the beta release 👍

@sergey-tihon sergey-tihon merged commit 1fb7336 into sergey-tihon:master Aug 15, 2021
@sergey-tihon
Copy link
Owner

I've released it as v1.7.0 but it will be nice to add more docs for this as separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Word Word related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants