Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the 2023_11 edition #856

Closed
ericnordelo opened this issue Dec 15, 2023 · 3 comments · Fixed by #995 · May be fixed by #866
Closed

Migrate to the 2023_11 edition #856

ericnordelo opened this issue Dec 15, 2023 · 3 comments · Fixed by #995 · May be fixed by #866
Assignees
@ericnordelo
Milestone
1. current

Comments

@ericnordelo
Copy link
Member

This edition is about reducing the default scope of corelib, requiring more explicit imports.
@TAdev0
Copy link
Contributor

TAdev0 commented Jan 30, 2024 •
edited

@ericnordelo @martriay may i be assigned to this issue? I think the migration should now use 2023_11 edition, which includes the same 2023_10 prelude + pub / pub(crate) keywords from 2.5.0

@martriay martriay linked a pull request Jan 30, 2024 that will close this issue
Update edition to 2023_10 #866
Open
4 tasks
@martriay
Copy link
Contributor

@TAdev0 thanks for asking! But this is being addressed already in #866, but since the PR wasn't properly linked this issue appeared in the "good to tackle" list. Fixed it now!

@TAdev0
Copy link
Contributor

TAdev0 commented Jan 30, 2024

@martriay thanks for the quick answer!

@martriay martriay added this to the after milestone Mar 4, 2024
@martriay martriay modified the milestones: 2. after, 3. later Mar 21, 2024
@andrew-fleming andrew-fleming modified the milestones: 3. after, 2. next Apr 30, 2024
@ericnordelo ericnordelo self-assigned this May 21, 2024
@ericnordelo ericnordelo mentioned this issue May 27, 2024
Merged
4 tasks
@ericnordelo ericnordelo changed the title Migrate to the 2023_10 edition Migrate to the 2023_11 edition May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericnordelo ericnordelo

Labels
None yet
Projects
None yet
Milestone
1. current
4 participants
@martriay @ericnordelo @andrew-fleming @TAdev0