Update edition to 2023_10 #866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cairo v2.4.0 introduced the notion of editions. New editions add new features but may include breaking changes. Editions are linearly increasing, i.e. if we have edition x<y<z, then we cannot upgrade to z without taking y's changes as well.
This PR adds edition to the project's Scarb.toml and makes the necessary changes so that the package compiles successfully. Edition 2023_10 narrows the part of the corelib which is available by default. To compile with this edition, this PR adds a bunch of use statements (mostly for
zeroableandpanic_with_felt252) for functionality that is no longer part of the prelude.PR Checklist