Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solidity/Cairo upgrades comparison #272

Merged
merged 9 commits into from May 1, 2022
Merged

Add Solidity/Cairo upgrades comparison #272

merged 9 commits into from May 1, 2022

Conversation

andrew-fleming
Copy link
Collaborator

Resolves #227.

martriay
martriay suggested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@martriay martriay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I'd also mention how the storage structure is not an issue in Cairoland

docs/Proxies.md Outdated Show resolved Hide resolved
martriay
martriay approved these changes May 1, 2022
View reviewed changes
Copy link
Contributor

@martriay martriay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

docs/Proxies.md Outdated Show resolved Hide resolved
@martriay martriay merged commit 6b23ef9 into OpenZeppelin:main May 1, 2022
@andrew-fleming andrew-fleming deleted the compare-upgrades branch May 1, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martriay martriay martriay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add solidity/cairo comparison to upgrades docs
2 participants
@andrew-fleming @martriay