Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change initialized visibility to @view #276

Merged
merged 1 commit into from Apr 19, 2022
Merged

fix: change initialized visibility to @view #276

merged 1 commit into from Apr 19, 2022

Conversation

0xSidius
Copy link
Contributor

No description provided.

@0xSidius 0xSidius mentioned this pull request Apr 12, 2022
Closed
andrew-fleming
andrew-fleming approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@andrew-fleming andrew-fleming merged commit 270c76f into OpenZeppelin:main Apr 19, 2022
@andrew-fleming
Copy link
Collaborator

Resolves #274.

AbdelStark added a commit to AbdelStark/cairo-contracts that referenced this pull request Apr 27, 2022
@AbdelStark
Squashed commit of the following:
34874be 
commit f96acc2
Author: Rootul Patel <rootulp@gmail.com>
Date:   Thu Apr 21 10:40:09 2022 -0400

    More cairo syntax highlighting (OpenZeppelin#280)

    * More cairo syntax highlighting

    Fixes OpenZeppelin#279

    Previously, code blocks used `c#` or `python` for syntax highlighting
    because `cairo` was not available. This change updates code blocks to
    use `cairo` now that it is available.

    The other changes were auto applied via markdownlint format on save. If
    reviewers request, they can be reverted.

    * Update README.md

    * Preserve colons after Returns and Accounts

    * Revert linter added newlines

commit 9b4d6a3
Author: Rootul Patel <rootulp@gmail.com>
Date:   Tue Apr 19 15:19:45 2022 -0400

    Prefer cairo syntax highlighting in Markdown files (OpenZeppelin#278)

commit 270c76f
Author: 0xSidius <100469911+0xSidius@users.noreply.github.com>
Date:   Tue Apr 19 03:00:08 2022 +0300

    fix: change `initialized` visibility to `@view` (OpenZeppelin#276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-fleming andrew-fleming andrew-fleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xSidius @andrew-fleming