Eth account support #361
Merged
Eth account support #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you kept |
martriay
suggested changes
Jun 16, 2022
tests/mocks/eth_account.cairo
Outdated
| pedersen_ptr : HashBuiltin*, | ||
| range_check_ptr | ||
| }(eth_address: felt): | ||
| Account.initializer(eth_address) |
There was a problem hiding this comment.
should we sanitize somehow?
There was a problem hiding this comment.
This looks really good, @JulissaDantes! I left a couple of comments and piggybacked on @martriay's comments and questions a bit
juniset
reviewed
Jun 17, 2022
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Martín Triay <martriay@gmail.com>
Co-authored-by: Martín Triay <martriay@gmail.com>
andrew-fleming
requested changes
Jun 25, 2022
There was a problem hiding this comment.
@JulissaDantes these improvements look excellent! I left a few questions and suggestions, but I think we're super close!
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
andrew-fleming
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
@JulissaDantes I left some super minor suggestions. Otherwise, this looks good to me! Great work :)
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
martriay
suggested changes
Jun 28, 2022
Co-authored-by: Martín Triay <martriay@gmail.com>
Co-authored-by: Martín Triay <martriay@gmail.com>
Co-authored-by: Martín Triay <martriay@gmail.com>
Co-authored-by: Martín Triay <martriay@gmail.com>
martriay
approved these changes
Jun 29, 2022
martriay
approved these changes
Jun 29, 2022
Co-authored-by: Martín Triay <martriay@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
Including secp256k1(the curve use by ethereum to generate their key pair and address) signature verification methods and eth_execute.
Adds a Ethereum signer in the test
signers.py, calledTestEthSigner, and instead of storing public and private key, stores private key and address(the last 20 bytes of the public key).The ethereum account preset contract stores the ethereum address instead of public key, as its internal public key, because a secp256k1 curve key pair public key is bigger than a felt, and also because the starkness verification method uses the Ethereum address instead of the public key so there was no point in changing the account library storages to include it, and never use it.
PR Checklist