Update to cairo v0.9.0 #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericglau
added a commit
to ericglau/contracts-wizard
that referenced
this pull request
Jun 22, 2022
* add releasing.md * clarify branch role
martriay
suggested changes
Jun 24, 2022
Comment on lines
+106
to
+113
| execution_info = await signer.send_transactions( | ||
| admin, | ||
| [ | ||
| (proxy.contract_address, 'name', []), | ||
| (proxy.contract_address, 'symbol', []), | ||
| (proxy.contract_address, 'decimals', []), | ||
| (proxy.contract_address, 'totalSupply', []) | ||
| ] |
Comment on lines
+135
to
+141
| # fetch values | ||
| execution_info = await signer.send_transactions( | ||
| admin, | ||
| [ | ||
| (proxy.contract_address, 'balanceOf', [admin.contract_address]), | ||
| (proxy.contract_address, 'balanceOf', [USER]), | ||
| (proxy.contract_address, 'totalSupply', []) |
There was a problem hiding this comment.
i guess this also speeds up testing?
There was a problem hiding this comment.
I forgot to compare! I'll confirm
There was a problem hiding this comment.
well it wasn't expected since the focus is not performance
tests/upgrades/test_Proxy.py
Outdated
Comment on lines
115
to
119
| # check initial admin | ||
| execution_info = await signer.send_transaction( | ||
| admin, proxy.contract_address, 'getAdmin', [] | ||
| ) | ||
| assert execution_info.result.response == [admin.contract_address] |
There was a problem hiding this comment.
is this necessary? it looks like we're testing the fixture instead of the library behavior
There was a problem hiding this comment.
I suppose it's not necessary, more of a sanity check. We can remove it
| @@ -15,7 +15,7 @@ passenv = | |||
| HOME | |||
| PYTHONPATH | |||
| deps = | |||
| cairo-lang==0.8.2.1 | |||
| cairo-lang==0.9.0 | |||
There was a problem hiding this comment.
we should probably release + pin nile too
Co-authored-by: Martín Triay <martriay@gmail.com>
Co-authored-by: Martín Triay <martriay@gmail.com>
martriay
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #360, #357.
Thiis PR updates the cairo-lang version in tox to
cairo-lang==0.9.0. Further, this PR refactors all of the test modules in order to conform to cairo-lang's v0.9.0 release. The bulk of this PR's proposed changes include:contract_defforcontract_classin theStarknetContractobjectThis PR also proposes to refactor the proxy pattern by:
declaringimplementation contracts instead of deploying them like normal contractslibrary_callandlibrary_call_l1_handlerinstead ofdelegate_callanddelegate_l1_handler_hashto storage and methods e.g.get_implementation_hashinstead ofget_implementationFinally, this PR also proposes to add the
AdminChangedevent to the Proxy library.PR Checklist