Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add erc20 docs #689

Closed
wants to merge 108 commits into from
Closed

Add erc20 docs #689

wants to merge 108 commits into from

Conversation

andrew-fleming
Copy link
Collaborator

Fixes #562.

PR Checklist

  • Tests
  • Tried the feature on a public network
  • Documentation

ericnordelo
ericnordelo reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Andrew, I know is still a Draft but left some comments already.

docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
@martriay martriay linked an issue Aug 14, 2023 that may be closed by this pull request
update erc20 docs #562
Closed
ericnordelo
ericnordelo reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left some comments regarding format.

docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
@andrew-fleming @ericnordelo
Apply suggestions from code review
6c39d25 
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
ericnordelo
ericnordelo approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent work!

martriay
martriay reviewed Sep 27, 2023
View reviewed changes
docs/modules/ROOT/pages/api/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
martriay
martriay reviewed Sep 29, 2023
View reviewed changes
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/erc20.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/erc20.adoc Outdated Show resolved Hide resolved
@martriay
Copy link
Contributor

should we also reorder the internals to match the external's order? e.g. _transfer is below _approve while transfer is above approve. Ideally this would match the module's order as well.

@martriay martriay deleted the branch OpenZeppelin:cairo-2 September 29, 2023 17:12
@martriay martriay closed this Sep 29, 2023
This was referenced Sep 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martriay martriay martriay approved these changes

@ericnordelo ericnordelo ericnordelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update erc20 docs
3 participants
@andrew-fleming @martriay @ericnordelo