Migrate AccessControl to component #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccess-control-to-component
…ccess-control-to-component
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
…ordelo/cairo-contracts into feat/migrate-ownable-to-components
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
…eat/migrate-ownable-to-components
…ordelo/cairo-contracts into feat/migrate-ownable-to-components
…ccess-control-to-component
…ccess-control-to-component
…ccess-control-to-component
Comment on lines
+72
to
+74
| +HasComponent<TContractState>, | ||
| +SRC5::HasComponent<TContractState>, | ||
| +Drop<TContractState> |
Comment on lines
+185
to
+188
| let mut contract = self.get_contract_mut(); | ||
| let mut src5_component = SRC5::HasComponent::< | ||
| TContractState | ||
| >::get_component_mut(ref contract); |
There was a problem hiding this comment.
I don't think we should do this right now, but I wonder if we can abstract this process out a bit in the future
There was a problem hiding this comment.
Cairo team said they were working on improving this, so probably worth waiting a bit anyway, but I agree.
…eat/migrate-access-control-to-component
andrew-fleming
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #769
PR Checklist