Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compatibility notice #861

Merged
merged 7 commits into from Jan 23, 2024
Merged

add compatibility notice #861

merged 7 commits into from Jan 23, 2024

Conversation

martriay
Copy link
Contributor

@martriay martriay commented Dec 27, 2023

Fixes #756.

Also added a few not previously discussed directives, like our rule regarding underscores. Open to discuss if needed.

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Left some comments.

docs/modules/ROOT/pages/backwards-compatibility.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/backwards-compatibility.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, Marto! Piggybacking off of Eric's review, I left a comment and a suggestion

docs/modules/ROOT/pages/backwards-compatibility.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/backwards-compatibility.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small suggestion. Otherwise, LGTM!

docs/modules/ROOT/pages/upgrades.adoc Outdated Show resolved Hide resolved
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com>
@martriay martriay merged commit 3b504e5 into main Jan 23, 2024
4 of 5 checks passed
@martriay martriay deleted the compatibility-notice branch January 23, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate adding backwards compatibility notice
3 participants