Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport doc fixes to release-v0.8.1 #884

Merged
merged 3 commits into from Jan 31, 2024
Merged

Backport doc fixes to release-v0.8.1 #884

merged 3 commits into from Jan 31, 2024

Conversation

martriay
Copy link
Contributor

@martriay martriay commented Jan 31, 2024 •
edited

Fixes #880.

@martriay
Address versioning and presets issues (#879)
a0b3e00 
* fix cairo version

* update class hashes

* fix scarb.toml version number

* add presets explainer

* update wording
@martriay martriay added this to the current milestone Jan 31, 2024
@martriay martriay linked an issue Jan 31, 2024 that may be closed by this pull request
Backport docs fixes to release-v0.8.1 #880
Closed
ericnordelo
ericnordelo reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides replacing the Compiled class hash for Sierra references, it looks good to me!

docs/modules/ROOT/pages/utils/_class_hashes.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/presets.adoc Show resolved Hide resolved
ericnordelo
ericnordelo approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

andrew-fleming
andrew-fleming approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martriay martriay merged commit eb2d321 into release-v0.8.1 Jan 31, 2024
@martriay martriay deleted the backport-fix-v0.8.1 branch January 31, 2024 19:05
@martriay martriay mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnordelo ericnordelo ericnordelo approved these changes

@andrew-fleming andrew-fleming andrew-fleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport docs fixes to release-v0.8.1
3 participants
@martriay @ericnordelo @andrew-fleming