Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change unwrap to unwrap_syscall #901

Merged
merged 5 commits into from Feb 12, 2024
Merged

Change unwrap to unwrap_syscall #901

merged 5 commits into from Feb 12, 2024

Conversation

andrew-fleming
Copy link
Collaborator

@andrew-fleming andrew-fleming commented Feb 7, 2024 •
edited

Fixes #902.

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

ericnordelo
ericnordelo approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrew-fleming andrew-fleming merged commit 87556e2 into OpenZeppelin:main Feb 12, 2024
5 checks passed
@andrew-fleming andrew-fleming deleted the fix-unwrap branch February 12, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martriay martriay martriay approved these changes

@ericnordelo ericnordelo ericnordelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some unwraps should be unwrap_syscalls
3 participants
@andrew-fleming @martriay @ericnordelo