SNIP 12 Utilities #935
Merged
SNIP 12 Utilities #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
… into feat/snip-12
martriay
reviewed
Mar 28, 2024
|
|
||
| #[starknet::interface] | ||
| trait INonces<TState> { | ||
| fn nonces(self: @TState, owner: ContractAddress) -> felt252; |
There was a problem hiding this comment.
i think felt252 might be just fine. but I wonder if you had any thoughts on using u256
There was a problem hiding this comment.
felt252 should be cheaper than u256 even in the future if we have a smaller felt. As Ariel confirmed, I don't think fel252 will be removed, so for this case, it suits us better IMO.
Comment on lines
+9
to
+16
| // selector!( | ||
| // "\"StarknetDomain\"( | ||
| // \"name\":\"shortstring\", | ||
| // \"version\":\"shortstring\", | ||
| // \"chainId\":\"shortstring\", | ||
| // \"revision\":\"shortstring\" | ||
| // )" | ||
| // ); |
There was a problem hiding this comment.
I wonder if we should just use the macro directly
There was a problem hiding this comment.
More expensive step(gas)-wise for a constant thing.
andrew-fleming
approved these changes
Mar 28, 2024
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409
PR Checklist