Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow importable test utils, update utils docs #963

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Allow importable test utils, update utils docs #963

merged 6 commits into from
Apr 11, 2024

Conversation

andrew-fleming
Copy link
Collaborator

Fixes #953. This PR also resolves #942. If this is too much, I can remove the latter fix.

PR Checklist

  • Tests (create a new scarb project and set this branch as a dep in scarb.toml to test the utils accessibility)
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

ericnordelo
ericnordelo approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrew-fleming andrew-fleming merged commit 47f804c into OpenZeppelin:main Apr 11, 2024
6 checks passed
@andrew-fleming andrew-fleming deleted the allow-importable-test-utils branch April 11, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnordelo ericnordelo ericnordelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test utils module can't be imported Update test utilties documentation entries.
2 participants
@andrew-fleming @ericnordelo