-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate new public key in Account #989
Merged
ericnordelo
merged 14 commits into
OpenZeppelin:main
from
ericnordelo:feat/validate-new-pub-key-#818
May 16, 2024
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
86551cd
feat: add logic and tests
ericnordelo 45f9fa3
feat: update CHANGELOG
ericnordelo 49ea133
feat: use ExTrait
ericnordelo 3030a9e
feat: update doc example
ericnordelo 9deb8e9
Update src/tests/account/test_account.cairo
ericnordelo 8b29077
Update src/tests/account/test_account.cairo
ericnordelo d2dfac2
Update docs/modules/ROOT/pages/api/account.adoc
ericnordelo 3e088ce
Update docs/modules/ROOT/pages/api/account.adoc
ericnordelo 3809f54
Update docs/modules/ROOT/pages/api/account.adoc
ericnordelo 6af8ece
Update src/account/account.cairo
ericnordelo e6be71d
Update src/account/account.cairo
ericnordelo 0086ab5
feat: move NEW_PUBKEY to constants
ericnordelo 71656d5
Merge branch 'feat/validate-new-pub-key-#818' of github.com:ericnorde…
ericnordelo 88a13a5
feat: format files
ericnordelo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm good call with using js. The Cairo highlighting looks a little bland here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, we should at some point improve the highlights extension.