Fix docs sections structure inconsistencies #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| To create an account, implement the {account-mixin} and set up the constructor to initialize the contract. | ||
| The {initializer} method sets the public key for the account contract and registers the account interface id. | ||
| A vanilla account contract looks like this: | ||
| First, let's take the example account we created before and deploy it: |
There was a problem hiding this comment.
Suggested change
| First, let's take the example account we created before and deploy it: | |
| First, let's take the example xref:accounts.adoc#usage[Starknet Account] we created before and deploy it: |
What do you think of this? We could remove the duplicate snippet if we include the link. Maybe it's better to have it directly underneath anyway, idk. Just an idea
There was a problem hiding this comment.
I think is easier for users to avoid going back and forth to check the code, I vote we keep the duplicate snippet.
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
…o/cairo-contracts into docs/fix-inconsistencies-#829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #829