Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename level 10 "Re-entrancy" to "Underflow" #571

Open
therealharpaljadeja opened this issue Jan 18, 2023 · 0 comments
Open

Rename level 10 "Re-entrancy" to "Underflow" #571

therealharpaljadeja opened this issue Jan 18, 2023 · 0 comments

Comments

@therealharpaljadeja
Copy link

I believe that even if there a re-entrancy possibility in the level contract, the main vulnerability is the underflow. Because if underflow is handled properly the re-entrancy attack will revert.

The level contract currently uses SafeMath but not for the subtraction operation and new compiler version (0.8.0 and later) handle it automatically.

So the main issue is underflow not re-entrancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant