Rename to @openzeppelin/contracts-ethereum-package #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Jul 15, 2019
|
Not sure we want to merge into master yet since this includes links to repos that don't yet exist, to the old zos docsite, etc. |
frangio
reviewed
Jul 15, 2019
package.json
Outdated
| "name": "openzeppelin-eth", | ||
| "version": "2.2.0", | ||
| "name": "@openzeppelin/contracts-ethereum-package", | ||
| "version": "2.2.1", |
There was a problem hiding this comment.
Shouldn't this be a release candidate, if the dependencies we're using are also release candidates?
|
LGTM. I have no idea why the CI is failing, but it was failing before too. 🙂 I'm contacting Travis support to migrate the repo to from travis-ci.org to travis-ci.com. |
@nico I'd merge either way, so we ensure we keep working on the renamed version. |
frangio
previously approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR against a new
@openzeppelinbranch, since I'm not sure if we want to merge this into master right away. I don't see any reason not to though!