Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for events in roles constructors #1354

Closed
frangio opened this issue Sep 26, 2018 · 1 comment
Closed

Add tests for events in roles constructors #1354

frangio opened this issue Sep 26, 2018 · 1 comment
Assignees
@nventuro
Labels
tests Test suite and helpers.

Comments

@frangio
Copy link
Contributor

frangio commented Sep 26, 2018

In #1329 we made sure that <Role>Added events are emitted at construction, but we don't have tests for it yet because it's not as easy to retrieve the decoded logs emitted in a constructor using Truffle.
@frangio frangio added kind:improvement tests Test suite and helpers. labels Sep 26, 2018
@nventuro nventuro mentioned this issue Oct 8, 2018
Merged
@Aniket-Engg Aniket-Engg mentioned this issue Oct 18, 2018
Merged
@Aniket-Engg
Copy link
Contributor

https://github.com/OpenZeppelin/openzeppelin-solidity/blob/80458ebc72f1c7c9695416edbe26690f72e406a0/test/examples/SimpleToken.test.js#L35
Here we test an event emitted in constructor. Should testing be done in the same way for roles constructors?

@nventuro nventuro mentioned this issue Nov 26, 2018
Merged
@nventuro nventuro mentioned this issue Dec 7, 2018
Closed
@dependabot-preview dependabot-preview bot mentioned this issue May 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nventuro nventuro

Labels
tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frangio @nventuro @Aniket-Engg