Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasNoTokens.sol issues Unused local variable compilation warning #367

Closed
yaronvel opened this issue Aug 13, 2017 · 3 comments
Closed

HasNoTokens.sol issues Unused local variable compilation warning #367

yaronvel opened this issue Aug 13, 2017 · 3 comments
Labels

Comments

@yaronvel
Copy link
Contributor

solc version 13.

zeppelin-solidity/contracts/ownership/HasNoTokens.sol:21:26: Warning: Unused local variable
  function tokenFallback(address from_, uint256 value_, bytes data_) external {
                         ^-----------^
,zeppelin-solidity/contracts/ownership/HasNoTokens.sol:21:41: Warning: Unused local variable
  function tokenFallback(address from_, uint256 value_, bytes data_) external {
                                        ^------------^
,zeppelin-solidity/contracts/ownership/HasNoTokens.sol:21:57: Warning: Unused local variable
  function tokenFallback(address from_, uint256 value_, bytes data_) external {
                                                        ^---------^
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Aug 28, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Aug 28, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Aug 28, 2017
Fixes compiler warnings abount unused local variables. Issue OpenZeppelin#367
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
Crazy and temporary solution, but it's working.
pash7ka added a commit to pash7ka/zeppelin-solidity that referenced this issue Nov 16, 2017
@theethernaut theethernaut self-assigned this Jan 4, 2018
@theethernaut theethernaut removed their assignment Jan 4, 2018
@frangio
Copy link
Contributor

frangio commented Jan 4, 2018

See #410 for a tentative solution that commented out the variable names. Note that the NatSpec documentation for the variables had to be removed, which is not really acceptable.

The proposed solution is to add a no-op mention of the variables. I think simply adding a statement for each variable works: from_; value_; data_;.

@shrugs
Copy link
Contributor

shrugs commented Jan 10, 2018

I don't get these errors on 0.4.18 after running truffle compile. What is your complication command?

@frangio
Copy link
Contributor

frangio commented Jan 16, 2018

True, this was fixed in #576!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants