Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility between ERC20Permit and Votes #3905

Closed
frangio opened this issue Dec 29, 2022 · 2 comments
Closed

Incompatibility between ERC20Permit and Votes #3905

frangio opened this issue Dec 29, 2022 · 2 comments
Milestone
5.0

Comments

@frangio
Copy link
Contributor

frangio commented Dec 29, 2022

Reported initially in #3872.

ERC20Permit and Votes both implement separate DOMAIN_SEPARATOR functions that are not virtual, so they can't be combined.

In the 4.x releases this issue shouldn't show up because users would combine ERC20Permit with ERC20Votes (and not Votes), which do not present an incompatibility.

However, in the current 5.0 code, following #3816, ERC20Votes is built on Votes and this will be an issue.

#3872 proposed making DOMAIN_SEPARATOR virtual, but this is not a good use of virtual functions because they would not be chained using super. I believe we should look for another solution.
@frangio frangio mentioned this issue Dec 29, 2022
Closed
3 tasks
@frangio frangio added this to the 5.0 milestone Dec 29, 2022
@frangio
Copy link
Contributor Author

frangio commented Jan 18, 2023

With #3968 we may be able to just remove DOMAIN_SEPARATOR from Votes to fix this.

@Amxx
Copy link
Collaborator

Amxx commented Jun 8, 2023

Fixed in #4297

@Amxx Amxx closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@frangio @Amxx