Make ERC20Votes independent from ERC20Permit #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
frangio
reviewed
Nov 16, 2022
JulissaDantes
changed the title
frangio
requested changes
Nov 25, 2022
Co-authored-by: Francisco <frangio.1@gmail.com>
…es/openzeppelin-contracts into refactor/erc20-votes
frangio
requested changes
Nov 27, 2022
frangio
reviewed
Nov 28, 2022
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 OpenZeppelin Contracts Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
Isn't it an issue that inheriting from both ERC20Permit and ERC20Votes would reuse same nonces for 2 different actions? I would suggest to refactor |
|
Proposed these changes here: #3848 |
This was referenced Dec 29, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3160
This PR introduces a new contract,
Nonces, to be used where keeping track of nonces is required. Also, ERC20Votes will now be inherited directly from EIP712 instead of using ERC20Permit.This is a breaking change due to the changes in the storage layout.
PR Checklist