Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make upgradeTo functions public #3923

Closed
frangio opened this issue Jan 3, 2023 · 1 comment · Fixed by #3959
Closed

Make upgradeTo functions public #3923

frangio opened this issue Jan 3, 2023 · 1 comment · Fixed by #3959
Labels
good first issue Low hanging fruit for new contributors to get involved!
Milestone
4.9

Comments

@frangio
Copy link
Contributor

frangio commented Jan 3, 2023

The upgradeTo and upgradeToAndCall functions are external virtual. As a result even though they can be overriden they can't be invoked via super, which is the correct way to override a function in this library.

From #3870.
@frangio frangio added this to the 4.9 milestone Jan 3, 2023
@frangio frangio mentioned this issue Jan 3, 2023
Closed
@Amxx Amxx added the good first issue Low hanging fruit for new contributors to get involved! label Jan 3, 2023
@PepperAndSalt999
Copy link

This one is for me :B

m-waqas88 added a commit to m-waqas88/openzeppelin-contracts that referenced this issue Jan 16, 2023
@m-waqas88
fix: make upgradeTo and upgradeToAndCall functions public (OpenZeppel…
2117f59 
…in#3923)
@m-waqas88 m-waqas88 mentioned this issue Jan 16, 2023
Merged
3 tasks
@harshasingamshetty1 harshasingamshetty1 mentioned this issue Jan 22, 2023
Closed
3 tasks
harshasingamshetty1 added a commit to harshasingamshetty1/openzeppelin-contracts that referenced this issue Jan 22, 2023
@harshasingamshetty1
fix: make upgradeTo and upgradeToAndCall functions public ( OpenZeppe…
4d24e67 
…lin#3923 )
@harshasingamshetty1 harshasingamshetty1 mentioned this issue Jan 22, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved!
Projects
None yet
Milestone
4.9
3 participants
@frangio @Amxx @PepperAndSalt999